Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve ForwardDiff tagging for HVP #596

Merged
merged 5 commits into from
Oct 30, 2024
Merged

fix: improve ForwardDiff tagging for HVP #596

merged 5 commits into from
Oct 30, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Oct 27, 2024 •
edited
Loading

Versions

  • Bump DI to v0.6.18

DI extensions

ForwardDiff:

  • Get rid of the custom HVP tag for ForwardDiff-over-something
  • Use a variant of shuffled_gradient instead, which makes the tag type easy to predict for preparation.
  • Now the inner preparation relies on additional arguments instead of a closure, which means ReverseDiff taping won't work: I have opened Fix performance for ForwardDiff-over-ReverseDiff #603 to keep track until I add a dedicated workaround.

DI source

  • Implement a new, private type of Context called PrepContext to pass preparation results as part of second-order operators.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (2fee793) to head (ec21e89).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   97.63%   97.62%   -0.02%     
==========================================
  Files         110      110              
  Lines        5377     5382       +5     
==========================================
+ Hits         5250     5254       +4     
- Misses        127      128       +1
Flag Coverage Δ
DI 98.71% <100.00%> (-0.03%) ⬇️
DIT 95.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review October 27, 2024 18:10
@gdalle gdalle mentioned this pull request Oct 30, 2024
Open
@gdalle gdalle changed the title Improve ForwardDiff tagging fix: improve ForwardDiff tagging for HVP Oct 30, 2024
@gdalle gdalle merged commit 346834e into main Oct 30, 2024
44 checks passed
@gdalle gdalle deleted the gd/better_tags branch October 30, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdalle @codecov-commenter